Get unassigned leases in leasesToTake #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulj
reviewed
Apr 30, 2024
| * @param asOfNanos time in nanoseconds to check expiration as-of | ||
| * @return true if lease lease is ready te taken | ||
| */ | ||
| public boolean isAvailable(long leaseDurationNanos, long asOfNanos) { |
There was a problem hiding this comment.
Prefer a Duration type instead of long nanos.
There was a problem hiding this comment.
Because we have this all the way up I'm not going to change it right now.
Comment on lines
376
to
384
| List<Lease> availableLeases = new ArrayList<>(); | ||
|
|
||
| for (Lease lease : allLeases.values()) { | ||
| if (lease.isExpired(leaseDurationNanos, lastScanTimeNanos)) { | ||
| expiredLeases.add(lease); | ||
| if (lease.isAvailable(leaseDurationNanos, lastScanTimeNanos)) { | ||
| availableLeases.add(lease); | ||
| } | ||
| } | ||
|
|
||
| return expiredLeases; | ||
| return availableLeases; |
There was a problem hiding this comment.
return allLeases.values().stream()
.filter(lease->lease.isAvailable(...))
.collect(toList())
There was a problem hiding this comment.
Done in next commit
| /** | ||
| * @param leaseDurationNanos duration of lease in nanoseconds | ||
| * @param asOfNanos time in nanoseconds to check expiration as-of | ||
| * @return true if lease lease is ready te taken |
There was a problem hiding this comment.
Fixed in next commit
lucienlu-aws
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when considering leases to take we only consider leases that are expired. This creates a delay for leases that have no owner unnecessarily. We should instead consider all unassigned leases as a potential lease to take
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.